Added ConcurrentDictionary#1
Open
Xanumbra wants to merge 2 commits intoPlayful-Interactive-Environments:masterfrom
Open
Added ConcurrentDictionary#1Xanumbra wants to merge 2 commits intoPlayful-Interactive-Environments:masterfrom
Xanumbra wants to merge 2 commits intoPlayful-Interactive-Environments:masterfrom
Conversation
ATrackingEntity - Changed List<Vector2> echoes to ConcurrentDictionary<int,Vector2> - Modified getters and setters - Refactored methods that accessed this values ATracklinkPlayerManager - Changed the way of feet data being added from the aPlayer to trackRecord
rohschinken
requested changes
Aug 29, 2022
rohschinken
reviewed
Aug 30, 2022
Collaborator
There was a problem hiding this comment.
Looks solid. 👍
Final approvement should be done by @hochleitner I guess since I'm not at PIE lab anymore and cannot test 😅
Collaborator
|
On 30.08.2022, at 17:47, Andreas Friedl ***@***.******@***.***>> wrote:
@rohschinken commented on this pull request.
Did not test but looks solid. 👍
Final approvement should be done by @hochleitner<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhochleitner&data=05%7C01%7CJeremiah.Diephuis%40fh-hagenberg.at%7Cf5c5b1953c8342aa904408da8a9ef3e4%7Cf88d4b736bb24b9aabc7eb96e5a6407c%7C1%7C0%7C637974713929633260%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=oMSyKgupJOF45LNY7SVIlt2SAss3DgPvxS0tK1QTRrQ%3D&reserved=0> I guess since I'm not at PIE lab anymore 😅
@rohschinken: You may not be employed by the PIE Lab anymore, but we greatly appreciate your feedback! Thanks!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Playful Interactive Environment Lab,
Here is the change that I promised. I checked if it compiles and it does! Feel free to refactor and change this as you see fit. I could not test this as it requires me to access the lab but maybe you can do at some point and let me know if something is wrong. Feel free to message and here is the changelog: